Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

fix: comments issues #626

Merged
merged 8 commits into from
Apr 5, 2024
Merged

fix: comments issues #626

merged 8 commits into from
Apr 5, 2024

Conversation

vitorvargasdev
Copy link
Contributor

No description provided.

@vitorvargasdev vitorvargasdev changed the base branch from main to lab April 5, 2024 13:59
@github-actions github-actions bot deleted a comment from SuperViz-Dev Apr 5, 2024
@github-actions github-actions bot deleted a comment from SuperViz-Dev Apr 5, 2024
@github-actions github-actions bot deleted a comment from SuperViz-Dev Apr 5, 2024
@github-actions github-actions bot deleted a comment from SuperViz-Dev Apr 5, 2024
@carlossantos74 carlossantos74 requested a review from Raspincel April 5, 2024 19:55
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.31%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 75% 100% 83.52% 28, 32, 33, 34, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/base/utils
   importStyle.ts 66.67% 100% 100% 3
src/web-components/comments
   comments.ts 88.24% 76.92% 87.65% 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 135, 64, 65, 66, 79, 80, 92, 93, 94, 95, 96, 97
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 96.43% 96.73% 181, 182, 183, 184, 185, 186, 187, 188, 232, 233
   annotation-pin.ts 100% 100% 95.19% 118, 123, 124, 125, 126, 183, 184, 185, 74, 75, 76, 77, 78
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 96.55% 97.69% 233, 234, 235, 238, 239, 267, 268, 365, 366, 380, 381
   comment-item.ts 100% 90.48% 96.45% 102, 103, 104, 281, 282, 89, 90, 91, 92, 95, 96
   content.ts 96.15% 81.82% 89.15% 108, 109, 39, 40, 43, 44, 45, 51, 52, 53, 67, 78, 79, 80, 81
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 87.65% 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 50, 51, 55, 56, 72, 81
   index.ts 100% 100% 100%
   mention-list.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   mention-list.style.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   autocomplete-handler.ts 100% 100% 98.29% 25, 26
   mention-handler.ts 100% 100% 100%
   watermark.ts 100% 100% 86.15% 15, 16, 17, 18, 19, 20, 21, 22, 23
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 92.73% 100% 97.60% 154, 155, 156, 157, 158, 159, 187, 221, 251, 83, 86
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 85.19% 100% 95.15% 109, 110, 111, 112, 114, 115, 116, 117, 152, 156, 221, 222, 223, 224, 88, 90, 91, 92, 94, 95, 96
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 89.62% 100% 97.07% 170, 171, 172, 182, 183, 184, 200, 201, 202, 243, 266, 326, 346, 347, 347, 348, 349, 350, 351, 56, 57, 62, 63
src/web-components/who-is-online/components
   dropdown.ts 90.20% 94.74% 96.78% 139, 140, 141, 142, 143, 144, 176, 176, 189, 190, 190, 191, 192, 193, 194
   index.ts 100% 100% 100%
   messages.ts 100% 80% 97.24% 123, 124, 132, 133, 141, 142
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   messages.style.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@carlossantos74 carlossantos74 requested review from carlossantos74 and Raspincel and removed request for Raspincel April 5, 2024 19:55
@SuperViz-Dev
Copy link
Contributor

Total Coverage: 92.29%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
   shims.d.ts 100% 100% 100%
src/common
src/common/types
   colors.types.ts 100% 100% 100%
   events.types.ts 100% 100% 100%
   meeting-colors.types.ts 100% 100% 100%
   participant.types.ts 100% 100% 100%
   realtime.types.ts 100% 100% 100%
   sdk-options.types.ts 100% 100% 100%
   stores.types.ts 100% 100% 100%
src/common/utils
   do-request.ts 100% 100% 87.50% 20
   index.ts 100% 100% 100%
   logger.ts 100% 100% 100%
   observable.ts 100% 100% 100%
   observer.ts 100% 100% 100%
   sleep.ts 0% 100% 100% 2
   use-store.ts 66.67% 100% 100% 30
src/components
   index.ts 100% 85.71% 100%
   types.ts 100% 100% 100%
src/components/base
   index.ts 100% 100% 100%
src/components/comments
   index.ts 94.44% 93.33% 96.40% 242, 301, 360, 361, 362, 364, 482, 520, 589, 702, 718
   types.ts 100% 100% 100%
src/components/comments/canvas-pin-adapter
   index.ts 54.55% 85.71% 88.09% 202, 249, 249, 249, 249, 250, 251, 254, 254, 255, 258, 328, 329, 331, 331, 331, 333, 333, 334, 336, 337, 340, 342, 391, 392, 393, 412, 423, 434, 438, 451, 472, 497, 517, 518, 529, 530, 531, 532, 533, 533, 533, 533, 533, 535, 535, 536, 536, 536, 536, 540, 542, 543
src/components/comments/html-pin-adapter
   index.ts 91.59% 96.55% 96.35% 277, 278, 279, 336, 363, 470, 471, 492, 493, 495, 495, 497, 498, 500, 500, 500, 500, 502, 503, 718, 719, 720, 797, 798, 799
src/components/presence-mouse
   index.ts 50% 100% 90% 10, 11
   types.ts 100% 100% 100%
src/components/presence-mouse/canvas
   index.ts 70.97% 76.19% 86.67% 102, 103, 104, 105, 125, 125, 127, 151, 154, 154, 155, 156, 230, 230, 230, 230, 290, 378, 69, 70, 71, 72, 73, 75, 76, 77, 78, 87, 88, 92, 93
src/components/presence-mouse/html
   index.ts 89.19% 96.97% 99.38% 245, 245, 247, 267, 519, 636
src/components/realtime
   index.ts 78.57% 81.25% 87.50% 177, 177, 179, 181, 182, 185, 187, 191, 192, 213, 82, 83, 97
   types.ts 100% 100% 100%
src/components/video
   index.ts 92.73% 98.08% 98.30% 213, 519, 647, 752, 752, 755, 755, 757
src/components/who-is-online
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/core
   index.ts 80% 57.14% 76.47% 114, 117, 121, 122, 124, 129, 129, 137, 139, 145, 69, 69, 71, 72, 73, 93, 94
src/core/launcher
   index.ts 70% 76% 87.28% 117, 119, 120, 124, 127, 299, 299, 300, 302, 308, 308, 310, 324, 325, 346, 347, 376, 376, 379, 380, 382, 387, 389, 391, 392, 429, 430, 433
src/services
src/services/api
   index.ts 100% 88.24% 88.33% 102, 103, 105, 111, 112, 113, 114
src/services/auth-service
   index.ts 100% 100% 100%
src/services/browser
   index.ts 100% 100% 100%
src/services/config
   index.ts 100% 100% 100%
src/services/connection-status
   index.ts 100% 100% 100%
src/services/event-bus
   index.ts 100% 100% 100%
src/services/frame-brick-layer
   index.ts 100% 100% 100%
src/services/io
   index.ts 100% 100% 100%
src/services/limits
   index.ts 75% 100% 100% 10
src/services/message-bridge
   index.ts 93.33% 100% 100% 80
src/services/realtime
   index.ts 100% 100% 100%
src/services/realtime/ably
   index.ts 63.37% 66.67% 72.47% 1004, 1005, 1008, 1011, 1011, 1012, 1013, 1015, 1016, 1017, 1020, 1024, 1024, 1026, 1027, 103, 1031, 1031, 1031, 1031, 1033, 1033, 1033, 1035, 1043, 1043, 1045, 1049, 1049, 1050, 1053, 1055, 1067, 1068, 1078, 1080, 1090, 1092, 1092, 1093, 1096, 111, 115, 116, 188, 253, 263, 314, 315, 323, 323, 324, 325, 328, 330, 330, 331, 334, 405, 407, 408, 418, 419, 420, 471, 472, 473, 474, 475, 475, 476, 477, 489, 491, 501, 503, 505, 507, 507, 507, 507, 508, 510, 527, 528, 538, 539, 549, 591, 592, 705, 705, 706, 709, 711, 711, 711, 712, 714, 719, 719, 721, 721, 721, 754, 886, 887, 888, 889, 891, 894, 895, 896, 898, 899, 901, 901, 901, 902, 903, 905, 906, 907, 911, 911, 912, 915, 932, 933, 934, 941, 942, 946, 95, 963, 963, 965, 966, 967, 99, 998, 998, 999
src/services/realtime/base
   index.ts 100% 100% 100%
src/services/remote-config-service
   index.ts 100% 100% 100%
src/services/slot
   index.ts 50% 83.33% 75.68% 44, 80, 80, 80, 80, 82, 82, 83, 84, 85, 88, 91, 91, 91, 91, 92, 93
src/services/stores
   index.ts 100% 100% 100%
src/services/stores/common
   utils.ts 100% 100% 100%
src/services/stores/global
   index.ts 0% 100% 94.74% 14, 15
src/services/stores/subject
   index.ts 100% 100% 100%
src/services/stores/who-is-online
   index.ts 0% 66.67% 80% 11, 12, 19, 20
src/services/video-conference-manager
   index.ts 61.90% 84.21% 93.53% 121, 124, 125, 126, 169, 174, 206, 207, 212, 213, 214, 217, 217, 218, 220, 221, 299, 311, 333, 360, 361, 362, 415, 449, 560, 572, 615, 619, 678
   types.ts 100% 100% 100%

@SuperViz-Dev
Copy link
Contributor

Total Coverage: 97.31%

Coverage Report
File Branch Funcs Lines Uncovered Lines
src
src/web-components
src/web-components/base
   index.ts 75% 100% 83.52% 28, 32, 33, 34, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69
src/web-components/base/styles
   icon-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   sv-hr.style.ts 100% 100% 100%
   typography.style.ts 100% 100% 100%
   variables.style.ts 100% 100% 100%
src/web-components/base/utils
   importStyle.ts 66.67% 100% 100% 3
src/web-components/comments
   comments.ts 88.24% 76.92% 87.65% 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 135, 64, 65, 66, 79, 80, 92, 93, 94, 95, 96, 97
   index.ts 100% 100% 100%
src/web-components/comments/components
   annotation-filter.ts 100% 100% 100%
   annotation-item.ts 100% 96.43% 96.73% 181, 182, 183, 184, 185, 186, 187, 188, 232, 233
   annotation-pin.ts 100% 100% 95.19% 118, 123, 124, 125, 126, 183, 184, 185, 74, 75, 76, 77, 78
   annotation-resolved.ts 100% 100% 100%
   comment-input.ts 100% 96.55% 97.69% 233, 234, 235, 238, 239, 267, 268, 365, 366, 380, 381
   comment-item.ts 100% 90.48% 96.45% 102, 103, 104, 281, 282, 89, 90, 91, 92, 95, 96
   content.ts 96.15% 81.82% 89.15% 108, 109, 39, 40, 43, 44, 45, 51, 52, 53, 67, 78, 79, 80, 81
   delete-comment-modal.ts 100% 100% 100%
   float-button.ts 100% 100% 87.65% 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 50, 51, 55, 56, 72, 81
   index.ts 100% 100% 100%
   mention-list.ts 100% 100% 100%
   topbar.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/comments/css
   annotation-filter.style.ts 100% 100% 100%
   annotation-item.style.ts 100% 100% 100%
   annotation-pin.style.ts 100% 100% 100%
   annotation-resolved.style.ts 100% 100% 100%
   comment-input.style.ts 100% 100% 100%
   comment-item.style.ts 100% 100% 100%
   comments.style.ts 100% 100% 100%
   content.style.ts 100% 100% 100%
   float-button.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   mention-list.style.ts 100% 100% 100%
   powered-by.style.ts 100% 100% 100%
   topbar.style.ts 100% 100% 100%
src/web-components/comments/utils
   autocomplete-handler.ts 100% 100% 98.29% 25, 26
   mention-handler.ts 100% 100% 100%
   watermark.ts 100% 100% 86.15% 15, 16, 17, 18, 19, 20, 21, 22, 23
src/web-components/dropdown
   index.style.ts 100% 100% 100%
   index.ts 92.73% 100% 97.60% 154, 155, 156, 157, 158, 159, 187, 221, 251, 83, 86
src/web-components/hello-world
   index.ts 100% 100% 100%
src/web-components/icon
   index.ts 100% 100% 100%
   types.ts 100% 100% 100%
src/web-components/modal
   index.ts 100% 100% 100%
   modal-container.ts 100% 100% 100%
   modal.ts 100% 100% 100%
src/web-components/modal/styles
   index.style.ts 100% 100% 100%
src/web-components/tooltip
   index.style.ts 100% 100% 100%
   index.ts 85.19% 100% 95.15% 109, 110, 111, 112, 114, 115, 116, 117, 152, 156, 221, 222, 223, 224, 88, 90, 91, 92, 94, 95, 96
   types.ts 100% 100% 100%
src/web-components/who-is-online
   index.ts 100% 100% 100%
   who-is-online.ts 89.62% 100% 97.07% 170, 171, 172, 182, 183, 184, 200, 201, 202, 243, 266, 326, 346, 347, 347, 348, 349, 350, 351, 56, 57, 62, 63
src/web-components/who-is-online/components
   dropdown.ts 90.20% 94.74% 96.78% 139, 140, 141, 142, 143, 144, 176, 176, 189, 190, 190, 191, 192, 193, 194
   index.ts 100% 100% 100%
   messages.ts 100% 80% 97.24% 123, 124, 132, 133, 141, 142
   types.ts 100% 100% 100%
src/web-components/who-is-online/css
   dropdown.style.ts 100% 100% 100%
   index.ts 100% 100% 100%
   messages.style.ts 100% 100% 100%
   who-is-online-style.ts 100% 100% 100%

@carlossantos74 carlossantos74 merged commit a0df1e1 into lab Apr 5, 2024
4 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 5.9.0-lab.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SuperViz-Dev
Copy link
Contributor

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossantos74 carlossantos74 carlossantos74 approved these changes

@Raspincel Raspincel Awaiting requested review from Raspincel

Assignees

@vitorvargasdev vitorvargasdev

Labels
released on @beta released on @lab released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitorvargasdev @SuperViz-Dev @carlossantos74